Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/block upgrade if vault in sealed #508

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Feat/block upgrade if vault in sealed #508

merged 3 commits into from
Jul 26, 2024

Conversation

jneo8
Copy link
Contributor

@jneo8 jneo8 commented Jul 19, 2024

Add pre-check step as first step global before all the steps to make sure vault is not in sealed.

follow: #507
relate: #467

@jneo8 jneo8 requested a review from a team as a code owner July 19, 2024 09:49
@jneo8 jneo8 force-pushed the feat/block-upgreade-if-vault-in-sealed branch 3 times, most recently from a5fd242 to f3e7ca1 Compare July 22, 2024 07:37
@jneo8
feat: Block upgrade if vault is in sealed status
b210260 
Add pre-check step as first step before all the steps to make
sure vault is not in sealed.
@jneo8 jneo8 force-pushed the feat/block-upgreade-if-vault-in-sealed branch from f3e7ca1 to b210260 Compare July 26, 2024 05:04
@chanchiwai-ray chanchiwai-ray changed the title Feat/block upgreade if vault in sealed Feat/block upgrade if vault in sealed Jul 26, 2024
chanchiwai-ray
chanchiwai-ray previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@chanchiwai-ray chanchiwai-ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's been tested on Danny's personal OpenStack deployment

cou/steps/vault.py Outdated Show resolved Hide resolved
tests/functional/tests/smoke.py Outdated Show resolved Hide resolved
samuelallan72
samuelallan72 previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me. I left some suggestions for improving the docs though (function naming, user-facing strings, etc.)

cou/steps/plan.py Outdated Show resolved Hide resolved
cou/steps/vault.py Outdated Show resolved Hide resolved
@jneo8 jneo8 dismissed stale reviews from samuelallan72 and chanchiwai-ray via 01672a0 July 26, 2024 07:32
samuelallan72
samuelallan72 previously approved these changes Jul 26, 2024
View reviewed changes
@jneo8 jneo8 merged commit 59f4cb9 into canonical:main Jul 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanchiwai-ray chanchiwai-ray chanchiwai-ray approved these changes

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jneo8 @samuelallan72 @chanchiwai-ray