Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update-status hook can be missing in some charms #475

Merged
merged 9 commits into from
Jul 5, 2024
Merged

Fix update-status hook can be missing in some charms #475

merged 9 commits into from
Jul 5, 2024

Conversation

chanchiwai-ray
Copy link
Contributor

Make running update-status safer by checking if hooks/update-status exists or not before running it.

fixes: #465

@chanchiwai-ray chanchiwai-ray self-assigned this Jul 2, 2024
@chanchiwai-ray chanchiwai-ray marked this pull request as ready for review July 2, 2024 04:12
@chanchiwai-ray chanchiwai-ray requested a review from a team as a code owner July 2, 2024 04:12
jneo8
jneo8 reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jneo8 jneo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, one non-blocking suggestion.

cou/utils/juju_utils.py Outdated Show resolved Hide resolved
@chanchiwai-ray chanchiwai-ray requested a review from jneo8 July 2, 2024 06:56
samuelallan72
samuelallan72 requested changes Jul 2, 2024
View reviewed changes
cou/utils/juju_utils.py Outdated Show resolved Hide resolved
jneo8
jneo8 previously approved these changes Jul 2, 2024
View reviewed changes
samuelallan72
samuelallan72 requested changes Jul 3, 2024
View reviewed changes
cou/utils/juju_utils.py Outdated Show resolved Hide resolved
jneo8
jneo8 previously approved these changes Jul 3, 2024
View reviewed changes
samuelallan72
samuelallan72 requested changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one blocking question about using 'no cover'. :)

cou/utils/juju_utils.py Outdated Show resolved Hide resolved
cou/utils/juju_utils.py Outdated Show resolved Hide resolved
@chanchiwai-ray chanchiwai-ray merged commit a770e4d into canonical:main Jul 5, 2024
4 checks passed
@chanchiwai-ray chanchiwai-ray deleted the bug/ceph-mon/SOLENG-408 branch July 5, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneo8 jneo8 jneo8 approved these changes

@samuelallan72 samuelallan72 samuelallan72 approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

Assignees

@chanchiwai-ray chanchiwai-ray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ceph-mon] upgrade failed: hooks/update-status: No such file or directory
3 participants
@chanchiwai-ray @samuelallan72 @jneo8