Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support enable-auto-restarts=False for rabbitmq-server. #413

Conversation

chanchiwai-ray
Copy link
Contributor

@chanchiwai-ray chanchiwai-ray commented May 22, 2024

Add support for enable-auto-restarts=False for rabbitmq-server.

@chanchiwai-ray chanchiwai-ray requested a review from a team as a code owner May 22, 2024 09:01
@rgildein rgildein marked this pull request as draft May 23, 2024 06:13
@chanchiwai-ray chanchiwai-ray force-pushed the feat/support-enable-auto-restarts-false-rmq/SOLENG-235 branch from e88e211 to c7b84e0 Compare May 23, 2024 06:24
@chanchiwai-ray chanchiwai-ray marked this pull request as ready for review May 23, 2024 08:53
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
tests/unit/apps/test_auxiliary.py Outdated Show resolved Hide resolved
@chanchiwai-ray chanchiwai-ray force-pushed the feat/support-enable-auto-restarts-false-rmq/SOLENG-235 branch from c7b84e0 to c58dc50 Compare May 28, 2024 07:38
@chanchiwai-ray
Copy link
Contributor Author

FYI:

Generating upgrade plan... ✔
Upgrade cloud from 'ussuri' to 'victoria'
        Verify that all OpenStack applications are in idle state
        Control Plane principal(s) upgrade plan
                Upgrade plan for 'rabbitmq-server' to 'victoria'
                        Upgrade software packages of 'rabbitmq-server' from the current APT repositories
                                Ψ Upgrade software packages on unit 'rabbitmq-server/0'
                                Ψ Upgrade software packages on unit 'rabbitmq-server/1'
                                Ψ Upgrade software packages on unit 'rabbitmq-server/2'
                        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/0'
                        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/1'
                        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/2'
                        Wait for up to 2400s for model 'cou' to reach the idle state
                        Change charm config of 'rabbitmq-server' 'source' to 'cloud:focal-victoria'
                        Wait for up to 2400s for model 'cou' to reach the idle state
                        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/0'
                        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/1'
                        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/2'
                        Wait for up to 2400s for model 'cou' to reach the idle state
                        Verify that the workload of 'rabbitmq-server' has been upgraded on units: rabbitmq-server/0, rabbitmq-server/1, rabbitmq-server/2


Would you like to start the upgrade? Continue (y/N): y
Running cloud upgrade...
Verify that all OpenStack applications are in idle state ✔

Upgrade plan for 'rabbitmq-server' to 'victoria'
        Upgrade software packages of 'rabbitmq-server' from the current APT repositories
                Ψ Upgrade software packages on unit 'rabbitmq-server/0'
                Ψ Upgrade software packages on unit 'rabbitmq-server/1'
                Ψ Upgrade software packages on unit 'rabbitmq-server/2'
        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/0'
        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/1'
        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/2'
        Wait for up to 2400s for model 'cou' to reach the idle state
        Change charm config of 'rabbitmq-server' 'source' to 'cloud:focal-victoria'
        Wait for up to 2400s for model 'cou' to reach the idle state
        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/0'
        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/1'
        Auto restarts is disabled, will execute run-deferred-hooks for unit: 'rabbitmq-server/2'
        Wait for up to 2400s for model 'cou' to reach the idle state
        Verify that the workload of 'rabbitmq-server' has been upgraded on units: rabbitmq-server/0, rabbitmq-server/1, rabbitmq-server/2

Continue (y/n): y
Upgrade plan for 'rabbitmq-server' to 'victoria' executed in 141 seconds ✔
Upgrade completed.

@chanchiwai-ray chanchiwai-ray force-pushed the feat/support-enable-auto-restarts-false-rmq/SOLENG-235 branch from c58dc50 to 43c23ed Compare May 28, 2024 07:40
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no sure if we need both wait, maybe yes, but for sure we should wait only for app itself and not whole mode.

cou/apps/auxiliary.py Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
@chanchiwai-ray chanchiwai-ray requested review from jneo8 and rgildein May 29, 2024 02:06
jneo8
jneo8 previously approved these changes May 29, 2024
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/auxiliary.py Outdated Show resolved Hide resolved
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pjack Pjack dismissed rgildein’s stale review May 30, 2024 08:13

The conversaion is resolved. I don't know why the status is not changed here.

@chanchiwai-ray chanchiwai-ray merged commit 015f5b2 into canonical:main May 30, 2024
5 checks passed
@chanchiwai-ray chanchiwai-ray deleted the feat/support-enable-auto-restarts-false-rmq/SOLENG-235 branch May 30, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants