current_os_release also consider OpenStack release set in configuration #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apps that are colocated with nova-compute will upgrade packages during nova-compute upgrade. To ensure to change the 'source' or 'openstack-origin' and run all the upgrade steps necessary, it's necessary to include the OpenStack release set in the application configuration. This patch also fix the post-upgrade generation to ensure that the require-osd-release option matches the ceph-osd version by passing control-plane apps where ceph-mon is and not on data-plane apps Closes: canonical#399, canonical#396 and canonical#380
gabrielcocenza
requested review from
Pjack,
aieri,
samuelallan72,
rgildein and
chanchiwai-ray
aieri
reviewed
May 2, 2024
rgildein
reviewed
May 2, 2024
aieri
requested changes
May 2, 2024
This was referenced May 6, 2024
aieri
reviewed
May 6, 2024
aieri
previously approved these changes
May 7, 2024
rgildein
previously approved these changes
May 7, 2024
or hacluster that supports more than one channel for an Openstack release.
rgildein
approved these changes
May 7, 2024
aieri
approved these changes
May 7, 2024
|
As in previous comments, we are piling more and more complexity in the base class... A refactor would be really useful here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps that are colocated with nova-compute will upgrade packages during nova-compute upgrade. To ensure to change the 'source' or 'openstack-origin' and run all the upgrade steps necessary, it's necessary to include the OpenStack release set in the application configuration.
This patch also fix the post-upgrade generation to ensure that the require-osd-release option matches the ceph-osd version by passing control-plane apps where ceph-mon is and not on data-plane apps
Closes: #399, #396 and #380