Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set_action_managed_upgrade #378

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Fix set_action_managed_upgrade #378

merged 3 commits into from
Apr 18, 2024

Conversation

gabrielcocenza
Copy link
Member

  • pythonlibjuju pass a string to configuration and not boolean and this was breaking the execution

@gabrielcocenza
Fix set_action_managed_upgrade
e1025a3 
- pythonlibjuju pass a string to configuration and not boolean and
  this was breaking the execution
@gabrielcocenza gabrielcocenza added bug Something isn't working high labels Apr 17, 2024
@gabrielcocenza gabrielcocenza self-assigned this Apr 17, 2024
@gabrielcocenza gabrielcocenza requested a review from a team as a code owner April 17, 2024 21:33
rgildein
rgildein approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/unit/steps/test_plan.py Show resolved Hide resolved
@gabrielcocenza gabrielcocenza merged commit 9694087 into canonical:main Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgildein rgildein rgildein approved these changes

@aieri aieri aieri approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

Assignees

@gabrielcocenza gabrielcocenza

Labels
bug Something isn't working high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielcocenza @aieri @rgildein