Run sanity checks in HypervisorUpgradePlanner #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run sanity checks for each in HypervisorUpgradePlanner. Improve unit tests for whole HypervisorUpgradePlanner. fixes: canonical#343
agileshaw
suggested changes
Apr 5, 2024
aieri
reviewed
Apr 5, 2024
rgildein
force-pushed
the
bug/BSENG-2264/hypervisors-sanity-checks
branch
from
2203add to
fdbfd7d
Compare
gabrielcocenza
requested changes
Apr 8, 2024
There was a problem hiding this comment.
This comment is not a blocker, but rather a personal opinion:
- I'm not enjoying the tweaks that we are making because of
_check_mismatched_versions.
Maybe doing the sanity check by AZ and pass units that are in a certain group from a app could makes things clear.
If we decide to continue like this I won't block but it feels to me that it's becoming more complex to understand the code.
agileshaw
suggested changes
Apr 8, 2024
Co-authored-by: TQ X <[email protected]>
Me neither. |
gabrielcocenza
approved these changes
Apr 11, 2024
agileshaw
approved these changes
Apr 11, 2024
No problems, I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run sanity checks for each in HypervisorUpgradePlanner. Improve unit tests for whole HypervisorUpgradePlanner.
fixes: #343