Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift application class #345

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add Swift application class #345

merged 2 commits into from
Mar 28, 2024

Conversation

agileshaw
Copy link
Contributor

@agileshaw agileshaw commented Mar 28, 2024

Add a new Swift application class for swift-proxy and swift-storage. This class will also raise ApplicationNotSupported exception when generating a plan.

Also make sure both swift-proxy and swift-storage are considered as data-plane applications.

fixes: #310

@agileshaw agileshaw requested a review from a team as a code owner March 28, 2024 20:08
@agileshaw agileshaw requested review from Pjack, aieri, jneo8 and rgildein March 28, 2024 20:08
@agileshaw agileshaw self-assigned this Mar 28, 2024
rgildein
rgildein previously approved these changes Mar 28, 2024
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add a new Swift application class for swift-proxy and swift-storage.
This class will also raise ApplicationNotSupported exception when
generating a plan.

Also make sure both swift-proxy and swift-storage are considered
as data-plane applications.
@agileshaw agileshaw merged commit 13a9fba into canonical:main Mar 28, 2024
4 checks passed
@agileshaw agileshaw deleted the bseng-2183 branch March 28, 2024 22:21
@rgildein rgildein added the bug Something isn't working label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add swift-storage and swift-proxy as data-plane apps
3 participants