Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enable and disable scheduler order on upgrade #337

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Fix enable and disable scheduler order on upgrade #337

merged 4 commits into from
Mar 28, 2024

Conversation

gabrielcocenza
Copy link
Member

@gabrielcocenza gabrielcocenza commented Mar 27, 2024 •
edited
Loading

  • disable the nova-compute scheduler should happen before upgrading any colocated application. E.g: It's not good practice to start upgrading cinder, colocated with nova-compute, without disabling the scheduler before
  • enable the nova-compute scheduler should happen after all apps of the hypervisor are done. E.g: It's not good practice enable the nova-compute scheduler if cinder, colocated with nova-compute, didn't upgrade yet.

Fix: #299

@gabrielcocenza
Fix enable and disable scheduler order on upgrade
88cd334 
- disable the nova-compute scheduler should happen before upgrading
  any colocated application. E.g: It's not good practice to start
  upgrading cinder, colocated with nova-compute,  without disabling
  the scheduler before
- enable the nova-compute scheduler should happen after all apps
  of the hypervisor are done. E.g: It's not good practice enable
  the nova-compute scheduler if cinder, colocated with nova-compute,
  didn't upgrade yet.
@gabrielcocenza gabrielcocenza self-assigned this Mar 27, 2024
@gabrielcocenza gabrielcocenza requested a review from a team as a code owner March 27, 2024 18:31
@gabrielcocenza gabrielcocenza added the bug Something isn't working label Mar 27, 2024
@gabrielcocenza gabrielcocenza mentioned this pull request Mar 27, 2024
Closed
agileshaw
agileshaw reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. But I think we should wait until #339 is merged to main (or rebase on it) so that we can update the documentation also in this PR. Otherwise it's easy to forget.

cou/apps/core.py Outdated Show resolved Hide resolved
cou/apps/core.py Outdated Show resolved Hide resolved
rgildein
rgildein suggested changes Mar 28, 2024
View reviewed changes
cou/apps/core.py Outdated Show resolved Hide resolved
cou/apps/core.py Outdated Show resolved Hide resolved
cou/apps/core.py Outdated Show resolved Hide resolved
cou/steps/hypervisor.py Show resolved Hide resolved
tests/unit/apps/test_core.py Outdated Show resolved Hide resolved
cou/apps/core.py Show resolved Hide resolved
rgildein
rgildein previously approved these changes Mar 28, 2024
View reviewed changes
tests/unit/apps/test_core.py Show resolved Hide resolved
@gabrielcocenza gabrielcocenza mentioned this pull request Mar 28, 2024
Closed
@gabrielcocenza gabrielcocenza force-pushed the fix-enable-disable-scheduler branch from 054cd60 to e40ba0c Compare March 28, 2024 22:28
rgildein
rgildein approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gabrielcocenza gabrielcocenza merged commit e00c582 into canonical:main Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgildein rgildein rgildein approved these changes

@agileshaw agileshaw agileshaw approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@aieri aieri Awaiting requested review from aieri aieri is a code owner automatically assigned from canonical/soleng-reviewers

@jneo8 jneo8 Awaiting requested review from jneo8 jneo8 is a code owner automatically assigned from canonical/soleng-reviewers

Assignees

@gabrielcocenza gabrielcocenza

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hypervisors should disable scheduler before starting upgrading
3 participants
@gabrielcocenza @agileshaw @rgildein