Add _check_ovn_support for ovn-chassis, ovn-central and ovn-dedicated-chassis
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agileshaw
reviewed
Mar 26, 2024
rgildein
force-pushed
the
bug/BSENG-2237/validate_ovn_in_sanity_checks
branch
from
480f694 to
cef63a4
Compare
There was a problem hiding this comment.
LGTM. I'm wondering if it worth to have a OVN class that we could share some functionality between ovn-subordinates and ovn-principals. This might be good for maintainability because we have some duplicated code on those classes and might be good to have a single source. If you folks agree, we can target this in another PR.
gabrielcocenza
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
_check_ovn_supportsanity check forovn-chassis,ovn-centralandovn-dedicated-chassis, instead of calling it directly inpre_upgrade_steps.based on: #328
fixes: #330