Fix rich operators on OpenStackRelease #307
Merged
+2
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix the issue described at https://bugs.python.org/issue35712 which silently returns False when __eq__ returns NotImplemented, rather than returning NotImplemented - implement the total_ordering[0] so we can avoid writing all the rich methods [0] https://docs.python.org/3/library/functools.html#functools.total_ordering
rgildein
approved these changes
Mar 13, 2024
aieri
approved these changes
Mar 13, 2024
agileshaw
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the issue described at https://bugs.python.org/issue35712 which silently returns False when eq returns NotImplemented, rather than returning NotImplemented
implement the total_ordering[0] so we can avoid writing all the rich methods
[0] https://docs.python.org/3/library/functools.html#functools.total_ordering