Introducing Machine for OpenStackApplication #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduction of the machine class with the following fields: - hostname, az, id and is_data_plane - juju_utils generate COU machine class based on juju Application data - Apps receive the machines with units deployed as attribute during the creation of the instance. - changed conftests to have a single source of truth for the unit tests.
- channel_codename property started failing coverage and we don't need to make another check because channel is already checked. - finished unit tests
gabrielcocenza
previously approved these changes
Mar 15, 2024
aieri
previously approved these changes
Mar 15, 2024
agileshaw
reviewed
Mar 15, 2024
Co-authored-by: TQ X <[email protected]>
aieri
approved these changes
Mar 16, 2024
gabrielcocenza
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In data-plane upgrade, we will need to have Machine object, which will be used during hypervisor upgrade.