Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix finishing indicator if HighestReleaseAchieved #205

Merged
merged 4 commits into from
Jan 2, 2024
Merged

fix finishing indicator if HighestReleaseAchieved #205

merged 4 commits into from
Jan 2, 2024

Conversation

rgildein
Copy link
Contributor

@rgildein rgildein commented Dec 15, 2023 •
edited
Loading

Without indicator finished, the message will break previous indicator.

  • add success for progess_indicator after HighestReleaseAchieved
  • improve message for HighestReleaseAchieved
  • improve message for logging indicator

original stdout

$ cou upgrade --model openstack
Logs of this execution can be found at /home/rgildein/.local/share/cou/log/cou-20231215205252.log  
Connected to 'openstack' ✔
Analyzing cloud... ✔
Generating upgrade plan... \The cloud is already at the latest OpenStack release 'yoga' compatible with series 'focal', and COU does not support series upgrade. Please manually upgrade series and run COU again.

new stdout

$ cou upgrade --model openstack
Full execution log: '/home/rgildein/.local/share/cou/log/cou-20231215205143.log'  
Connected to 'openstack' ✔
Analyzing cloud... ✔
Generating upgrade plan... ✔
No upgrades available for OpenStack Yoga on Ubuntu Focal.
Newer OpenStack releases may be available after upgrading to a later Ubuntu series.

@rgildein rgildein added the bug Something isn't working label Dec 15, 2023
@rgildein rgildein self-assigned this Dec 15, 2023
@rgildein rgildein requested review from a team, Pjack, aieri, agileshaw and jneo8 December 15, 2023 18:55
agileshaw
agileshaw suggested changes Dec 15, 2023
View reviewed changes
cou/cli.py Show resolved Hide resolved
cou/cli.py Show resolved Hide resolved
@agileshaw agileshaw mentioned this pull request Dec 15, 2023
Closed
agileshaw
agileshaw approved these changes Dec 15, 2023
View reviewed changes
cou/cli.py Show resolved Hide resolved
tests/unit/test_cli.py Show resolved Hide resolved
agileshaw
agileshaw suggested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous approval was given accidentally.

agileshaw
agileshaw approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gabrielcocenza
gabrielcocenza approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@gabrielcocenza gabrielcocenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@rgildein rgildein merged commit ebcb9a3 into canonical:main Jan 2, 2024
3 checks passed
@rgildein rgildein deleted the bug/fix-indicator-handling branch January 2, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcocenza gabrielcocenza gabrielcocenza approved these changes

@agileshaw agileshaw agileshaw approved these changes

@Pjack Pjack Awaiting requested review from Pjack

@aieri aieri Awaiting requested review from aieri

@jneo8 jneo8 Awaiting requested review from jneo8

Assignees

@rgildein rgildein

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgildein @agileshaw @gabrielcocenza