Skip to content

Commit

Permalink
add global and func test concurrency (#301)
Browse files Browse the repository at this point in the history
Right now we are using global concurrency for workflow name and like
this we are not running even lint and unit tests, which are run on
GitHub runner instead of self-hosted one. That's why I do not see reason
to block them to be run.

We also decided to use official GitHub runner for functional tests
instead of self-hosted runner.
  • Loading branch information
rgildein authored Mar 14, 2024
1 parent 7117330 commit 376522e
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/check.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@

name: Check workflow running linter, unit and functional tests

concurrency:
group: ${{ github.workflow }}


on:
workflow_call:
workflow_dispatch:
Expand All @@ -15,6 +11,11 @@ on:
- '**.md'
- '**.rst'

concurrency:
# We do not want to run multiple jobs for single PR.
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
lint-unit:
name: Lint checkers and unit tests
Expand Down Expand Up @@ -61,7 +62,7 @@ jobs:
func:
name: Functional tests
needs: snap-build
runs-on: [self-hosted, large]
runs-on: ubuntu-latest
timeout-minutes: 120
steps:
- uses: actions/checkout@v4
Expand Down

0 comments on commit 376522e

Please sign in to comment.