Fix initialization of mysqld #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
approved these changes
Feb 3, 2023
jardon
force-pushed
the
fix-initialize
branch
from
a321317
to
d19084c
Compare
paulomach
approved these changes
Feb 10, 2023
| ln -sf /root/parts/packages-deb/install/usr/lib/x86_64-linux-gnu/libaio.so.1 /usr/lib/x86_64-linux-gnu/libaio.so.1 | ||
| rm -rf /var/lib/mysql/ | ||
| mysqld --initialize | ||
| cp -r /var/lib/mysql $CRAFT_STAGE/var/lib |
There was a problem hiding this comment.
does it make sense to use cp -ar here so it will preserve ownership (and avoid next line)
There was a problem hiding this comment.
I don't believe that works because at the time of creation, the mysql user does not exist and so ownership has to be set to a user id which will eventually be the id for the mysql user that is created later.
I could be wrong about that, but from my understanding, that would be an issue.
shayancanonical
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
mysql was not initialized correctly
Solution
mysql is initialized with a startup script that creates the necessary folders and sets permissions
Context
Testing
Built, ran locally with docker. Need to throw the image in the associated charm for further testing.
Release Notes
Added initialization script
Created missing default directories
Set permissions for the mysql user