Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocks: publish jobs should not overwrite images with the same tag unless forced #32

Closed
orfeas-k opened this issue Dec 5, 2023 · 1 comment · Fixed by #36
Closed

rocks: publish jobs should not overwrite images with the same tag unless forced #32

orfeas-k opened this issue Dec 5, 2023 · 1 comment · Fixed by #36
Labels
enhancement New feature or request

Comments

@orfeas-k
Copy link
Contributor

orfeas-k commented Dec 5, 2023 •
edited
Loading

What needs to get done

Update CI to check and abort publishing if an image with the same tag exists.

Why it needs to get done

Since a publish job can be triggered on dispatch, it is possible it will try to publish an image with a tag while there is already one published.

We should update our publish workflows (one is here) in order to make sure our CI protects us from this, since this is a mistake that can happen in silence.
@orfeas-k orfeas-k added the enhancement New feature or request label Dec 5, 2023
This was referenced Dec 6, 2023
Open
Closed
@orfeas-k orfeas-k changed the title Make sure publish jobs do not overwrite images with the same tag unless forced rocks: publish jobs should not overwrite images with the same tag unless forced Dec 6, 2023
@orfeas-k orfeas-k mentioned this issue Dec 7, 2023
Merged
@orfeas-k orfeas-k reopened this Dec 11, 2023
@orfeas-k orfeas-k reopened this Dec 11, 2023
@orfeas-k orfeas-k reopened this Dec 12, 2023
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5128.

This message was autogenerated

orfeas-k added a commit that referenced this issue Dec 14, 2023
@orfeas-k
feat: Refactor ROCKs CI workflows (#36)
17fd7ff 
* Add `publish-rock.yaml` workflow
* Add `integration-test-rock.yaml` workflow
* Add `sanity-test-rock.yaml` workflow
* Add `scan-rock.yaml` workflow
* Add `build-rock.yaml` workflow
* Rename `build-scan-test` to `build-scan-test-publish.yaml`
* Make `publish-rock.yaml` check if Docker image exists
* Rename to `get-rocks-modified.yaml` (replace `_` with `-`)
* Rename to `get-rocks-modified-and-build-scan-test-publish.yaml` (replace `_` with `-`)
* Rename `build-scan-and-test-rock.yaml` to `build-scan-test-publish-rock.yaml`
* Refactor `build-scan-test-publish-rock.yaml` to call reusable WFs
* Refactor `build_and_publish_rock.yaml` to call reusable WFs
* Add `python-version` as input to `integration-test` WF

Refs #31
Closes #28
Closes #32
Closes #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rocks): Refactor on_pull_request workflows canonical/charmed-kubeflow-workflows
1 participant
@orfeas-k