feat: Run UATs from a remote commit #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to run tests either from: * a remote branch of charmed-kubeflow-uats repository. * the local copy of the repository
|
@orfeas-k would it be possible to run a git command and detect the commit from which the test runs, and then use this to fetch from when running remotely? Essentially to avoid having folks to define the branch/commit manually and have the driver code detect the commit and tell it to the remote code. But this is a high level comment, and maybe not feasible depending on how the code is executed in the remote. |
orfeas-k
force-pushed
the
kf-5473-add-remote-option
branch
from
e5e2a7b to
71fc6d4
Compare
Remove `branch` option and automatically grab currently checked out commit and use that for remote. Details in #65
orfeas-k
force-pushed
the
kf-5473-add-remote-option
branch
from
71fc6d4 to
68482cd
Compare
|
@kimwnasptd Changed implementation to grab the checked out commit from the local repository and use this to sync the tests in the created volume. If the commit doesnt exist, tests will fail and log |
NohaIhab
reviewed
Mar 29, 2024
orfeas-k
changed the title
orfeas-k
added a commit
to canonical/bundle-kubeflow
that referenced
this pull request
Mar 29, 2024
Update UATs environment used in `full-bundle-tests.yaml` used after changes in canonical/charmed-kubeflow-uats#67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #65. Implemented solution is described in #65 (comment). It essentially add the option of running tests either from:
charmed-kubeflow-uatsrepository.Closes #65
Testing
In order to test this, one needs to:
tox -e kubeflow-local.tox -e kubeflow-remote -- --branch kf-5473-add-remote-option.That being said, I 've tested option 2 in an AKS cluster only (it works) and it will be tested also by the CI once it is implemented in canonical/bundle-kubeflow#850. It should work in EKS too but if it doesn't, we already have a different issue for EKS #55 and a task too canonical/bundle-kubeflow#802, thus if it doesn't work, it will be tackled as part of those efforts.