Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to charmcraft 3 poetry plugin #18

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

carlcsaposs-canonical
Copy link
Contributor

data-platform-workflows and charmcraftcache are migrating from charmcraft 2 to 3 to enable 24.04 based charms & to enable use of the poetry plugin, which fixes several longstanding issues with charmcraft (e.g. canonical/charmcraft#1077)

reneradoi
reneradoi previously approved these changes Jan 10, 2025
Copy link
Collaborator

@reneradoi reneradoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Carl! The build looks good on CI, no objections from my side.

@skourta Please have a look at this PR on Monday, Carl wants to merge until Monday EOD.

skourta
skourta previously approved these changes Jan 13, 2025
Copy link
Contributor

@skourta skourta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reneradoi
reneradoi previously approved these changes Jan 13, 2025
skourta
skourta previously approved these changes Jan 13, 2025
@carlcsaposs-canonical carlcsaposs-canonical marked this pull request as ready for review January 14, 2025 09:40
@reneradoi reneradoi self-requested a review January 14, 2025 09:47
@carlcsaposs-canonical carlcsaposs-canonical merged commit 4277093 into main Jan 14, 2025
7 of 8 checks passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the charmcraft-3-migration branch January 14, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants