charm_builder: install binary python packages (CRAFT-601) #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charm plugin property `charm-binary-python-packages` can be used to list binary packages to install from PyPI. Packages may still be installed from sources if they're only available in source format. Signed-off-by: Claudio Matsuoka <[email protected]>
Github is deprecating access with the unencrypted git protocol. Change github requirement data transfer protocol to https. Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
cmatsuoka
force-pushed
the
charm-binary-python-packages
branch
from
1308105 to
21eb612
Compare
|
Rebased on master. |
Option `--prefer-binary` is only available in pip 20.x and bionic installs 9.x. Options are to update pip to a newer version and keep using `--prefer-binary`; change the option to `--only-binary` (in this case installation of packages only available in source form or depending on packages only available in source form would fail); or not specify any option related to binary installation (which would result in installation from source if tha latest version of a package is only available in source form, which is a possible situation but likely to be a corner case). This commit implements the third solution. Signed-off-by: Claudio Matsuoka <[email protected]>
cmatsuoka
force-pushed
the
charm-binary-python-packages
branch
from
21eb612 to
9010f4b
Compare
facundobatista
suggested changes
Nov 3, 2021
requirements-dev.txt
Outdated
| @@ -61,4 +61,4 @@ tomli==1.2.2 | |||
| typing-extensions==3.10.0.2 | |||
| urllib3==1.26.7 | |||
| zipp==3.6.0 | |||
| git+git://github.com/canonical/craft-cli.git@4af19f9c0da733321dc754be1180aea28f3feeb1 | |||
| git+https://github.com/canonical/craft-cli.git@4af19f9c0da733321dc754be1180aea28f3feeb1 | |||
There was a problem hiding this comment.
Github is deprecating access using the unencrypted git protocol (see https://github.blog/2021-09-01-improving-git-protocol-security-github/). This is not effective yet but there was a brownout on Nov 02 when this PR was submitted. Also note that all entries using non-published packages will be removed before the next release.
snap/snapcraft.yaml
Outdated
| @@ -72,6 +72,7 @@ parts: | |||
| plugin: nil | |||
| build-packages: | |||
| - python3-dev | |||
| - git | |||
There was a problem hiding this comment.
What this is needed for?
There was a problem hiding this comment.
This was needed to be able to install packages using git+https and can be removed when those lines are removed. I will revert these changes since this brownout period ended (if we leave this to be changed later we'll forget to remove the git entry from snapcraft.yaml).
Github will phase out data transfers using the unencrypted git protocol (see https://github.blog/2021-09-01-improving-git-protocol-security-github/). Revert changes now because it adds 'git' to the snap build package list. Unpublished dependencies will be removed prior to release. Signed-off-by: Claudio Matsuoka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charm plugin property
charm-binary-python-packagescan be used tolist binary packages to install from PyPI. Packages may still be
installed from sources if they're only available in source format.
Signed-off-by: Claudio Matsuoka [email protected]