Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix some edge cases with resource uploads #1736

Merged
merged 8 commits into from
Jul 18, 2024
Merged

fix: fix some edge cases with resource uploads #1736

merged 8 commits into from
Jul 18, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Jul 16, 2024 •
edited
Loading

Fixes #1712

@lengau lengau requested a review from a team July 17, 2024 19:04
@lengau lengau marked this pull request as ready for review July 17, 2024 19:04
@lengau lengau changed the title fix(tests): make resources test more resilient fix: fix some edge cases with resource uploads Jul 17, 2024
@lengau lengau enabled auto-merge July 17, 2024 19:05
lengau
lengau commented Jul 17, 2024
View reviewed changes
charmcraft/models/project.py Outdated Show resolved Hide resolved
@lengau lengau disabled auto-merge July 17, 2024 19:28
mattculler
mattculler approved these changes Jul 17, 2024
View reviewed changes
charmcraft/application/commands/store.py Outdated Show resolved Hide resolved
tests/spread/store/resources/task.yaml Show resolved Hide resolved
@lengau lengau requested a review from a team July 17, 2024 19:41
@lengau lengau enabled auto-merge July 17, 2024 21:00
dariuszd21
dariuszd21 approved these changes Jul 18, 2024
View reviewed changes
charmcraft/application/commands/store.py Show resolved Hide resolved
tests/spread/store/resources/task.yaml Outdated Show resolved Hide resolved
@lengau lengau added this pull request to the merge queue Jul 18, 2024
@lengau lengau removed this pull request from the merge queue due to a manual request Jul 18, 2024
@lengau lengau enabled auto-merge July 18, 2024 16:29
@lengau lengau disabled auto-merge July 18, 2024 17:09
@lengau lengau merged commit 97603da into main Jul 18, 2024
15 of 17 checks passed
@lengau lengau deleted the ci/resources branch July 18, 2024 17:10
@BrewTestBot BrewTestBot mentioned this pull request Jul 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattculler mattculler mattculler approved these changes

@dariuszd21 dariuszd21 dariuszd21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store resources spread test is broken
3 participants
@lengau @dariuszd21 @mattculler