feat: django-framework extension #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces an experimental Flask extension for the Juju 12-factor charm ecosystem in charmcraft.
Introduce a new profile called `flask-framework` to the charmcraft init command to create basic projects for 12-factor Flask charms
fixes canonical#1369 Multi-platform build: https://launchpad.net/~lengau/+snap/snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca - [x] [armhf](https://launchpad.net/~lengau/+snap/snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca/+build/2296258) - [x] [arm64](https://launchpad.net/~lengau/+snap/snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca/+build/2296257) - [x] [ppc64el](https://launchpad.net/~lengau/+snap/snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca/+build/2296256) ([buildlog](https://launchpad.net/~lengau/+snap/snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca/+build/2296256/+files/buildlog_snap_ubuntu_jammy_ppc64el_snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca_BUILDING.txt.gz)) - [x] [s390x](https://launchpad.net/~lengau/+snap/snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca/+build/2296255) ([buildlog](https://launchpad.net/~lengau/+snap/snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca/+build/2296255/+files/buildlog_snap_ubuntu_jammy_s390x_snapcraft-charmcraft-084dfcb7321972fd248f5d75baf555ca_BUILDING.txt.gz))
Add the `django-framework` extension, which is similar to the `flask-framework` but specifically designed for the Django framework. The `flask-framework` has been refactored in hope to be more aligned with the extension system in charmcraft. Due to the fact that we are still waiting for some changes in other libraries to land, one spread test might fail. Please review the current content, and I will update the pull request once the changes in other libraries are merged. --------- Co-authored-by: Alex Lowe <[email protected]>
jdkandersson
changed the title
lengau
reviewed
Apr 23, 2024
tigarmo
approved these changes
May 2, 2024
|
Given |
|
Ok, I think I added |
lengau
approved these changes
May 8, 2024
lengau
changed the title
6 tasks
auto-merge was automatically disabled
June 18, 2024 01:47
Head branch was pushed to by a user without write access
jdkandersson
force-pushed
the
feature/12f
branch
from
9e5312d
to
39b5e26
Compare
sergiusens
reviewed
Jun 19, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @sergiusens we are proposing to keep the django extension in
latest/edgein experimental and not pick it for candidate releases until the extension is no longer experimental.