fix: support type:secret in config.options
#1624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cf. canonical/operator#1166 where this was raised in ops. |
|
Argh, the CLA check failed because I carelessly did the merge in the GitHub UI and didn't associate it with my Canonical email address. Is there an easy way to fix that, like signing the CLA with my personal address also? |
|
@tonyandrewmeyer Would you be able to rebase with the commit author set to your Canonical email to fix the CLA check? There also seem to be various CI failures (which I haven't looked at). |
|
Opened a replacement PR #1625. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Juju 3.1, the
config.optionssection ofcharmcraft.yaml(or the olderconfig.yaml) has supported atypevalue ofsecret(for user secrets). This is missing from the documentation right now, but the Juju team are working on fixing that.This PR adds support for
type: secretin config options.