fix: reorganise charmcraft.yaml preprocessing #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a few related changes: 1. Extensions are applied on the rawest charmcraft.yaml data we have 2. Charms with a "bases" key (not just bundles) get a default part. 3. Always expect a dictionary for parts.
lengau
force-pushed
the
CRAFT-2645/no-parts-side-effect
branch
from
f3bf38d
to
862d307
Compare
mr-cal
approved these changes
Apr 1, 2024
tigarmo
approved these changes
Apr 2, 2024
tonyandrewmeyer
pushed a commit
to tonyandrewmeyer/charmcraft
that referenced
this pull request
Apr 4, 2024
This makes a few related changes: 1. Extensions are applied on the rawest charmcraft.yaml data we have 2. Charms with a "bases" key (not just bundles) get a default part. 3. Always expect a dictionary for parts.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few related changes: