Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ruff configuration to starbase v1 #1232

Merged
merged 3 commits into from
Aug 22, 2023
Merged

tools: update ruff configuration to starbase v1 #1232

merged 3 commits into from
Aug 22, 2023

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Aug 19, 2023 •
edited
Loading

Broken into commits for ease of reading.

@lengau lengau marked this pull request as ready for review August 22, 2023 18:59
@lengau lengau requested review from tigarmo and mr-cal August 22, 2023 18:59
mr-cal
mr-cal approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/test_infra.py Show resolved Hide resolved
charmcraft/commands/init.py Show resolved Hide resolved
@lengau lengau requested a review from syu-w August 22, 2023 20:06
syu-w
syu-w approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@syu-w syu-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you wanna do this after the rebase

@lengau lengau merged commit 5efcfc8 into main Aug 22, 2023
25 of 26 checks passed
@lengau lengau deleted the lint branch August 22, 2023 20:10
@lengau
Copy link
Collaborator Author

lengau commented Aug 22, 2023

@syu-w I did, but I ended up creating a circular dependency with things I wanted to do and this cut that of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syu-w syu-w syu-w approved these changes

@mr-cal mr-cal mr-cal approved these changes

@tigarmo tigarmo Awaiting requested review from tigarmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lengau @mr-cal @syu-w