models: do not enforce pydantic models on legacy files #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syu-w
force-pushed
the
unenforced-metadata
branch
from
cd6abaf
to
5867f7a
Compare
lengau
requested changes
Aug 8, 2023
syu-w
force-pushed
the
unenforced-metadata
branch
4 times, most recently
from
f24af81
to
b876def
Compare
lengau
reviewed
Aug 8, 2023
tests/spread/smoketests/metafiles/unenforced_bad_yaml/task.yaml
Outdated
Show resolved
Hide resolved
lengau
approved these changes
Aug 8, 2023
sergiusens
reviewed
Aug 9, 2023
sergiusens
reviewed
Aug 9, 2023
| yaml.dump( | ||
| charmcraft_config.config.dict( | ||
| include={"options"}, exclude_none=True, by_alias=True | ||
| if charmcraft_config.config: |
There was a problem hiding this comment.
not for this PR, but for the next release, we probably want for b876def#diff-393cfb3bc4ec4de9d80e214583c4e8d6a4ca712299b7416d32391263674e3238R26 to inherit from YamlModel, that would clean this up a bit.
sergiusens
requested changes
Aug 10, 2023
tests/spread/smoketests/metafiles/unenforced_bad_yaml/task.yaml
Outdated
Show resolved
Hide resolved
syu-w
force-pushed
the
unenforced-metadata
branch
12 times, most recently
from
a3fc7e2
to
f725f8a
Compare
Only warning when found invalid file for backward compatible.
syu-w
force-pushed
the
unenforced-metadata
branch
from
f725f8a
to
c1256e1
Compare
lengau
approved these changes
Aug 11, 2023
sergiusens
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only warning when found invalid file for backward compatible.
Fixes #1208