command: charmcraft init to use charmcraft.yaml only #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syu-w
force-pushed
the
move-charmcraft-init
branch
from
f9b3a0d
to
153bd08
Compare
|
Blocked by: |
syu-w
force-pushed
the
move-charmcraft-init
branch
2 times, most recently
from
7da3782
to
a5cf958
Compare
lengau
reviewed
Jul 12, 2023
lengau
reviewed
Jul 12, 2023
syu-w
force-pushed
the
move-charmcraft-init
branch
3 times, most recently
from
763a60d
to
f5c9904
Compare
syu-w
force-pushed
the
move-charmcraft-init
branch
3 times, most recently
from
7e44ed3
to
938a513
Compare
syu-w
force-pushed
the
move-charmcraft-init
branch
from
938a513
to
f4bbbbf
Compare
|
I think we're better off just removing the |
lengau
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
As long as @jnsgruk and @sergiusens are on the same page as each other about removing the -legacy templates I'm happy with that. Let's check in stand-up today and then you can merge either this as-is or without the legacy directories.
Thanks for all this work!
syu-w
force-pushed
the
move-charmcraft-init
branch
2 times, most recently
from
4d70b58
to
c367e4d
Compare
syu-w
force-pushed
the
move-charmcraft-init
branch
from
c367e4d
to
dbd8dfc
Compare
Use unified charmcraft.yaml by default, that included `metadata.yaml`, `actions.yaml` and `config.yaml`. Also added profiles descriptions and updated URL.
syu-w
force-pushed
the
move-charmcraft-init
branch
from
dbd8dfc
to
fc157ad
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use unified charmcraft.yaml by default, that included
metadata.yaml,actions.yamlandconfig.yaml.Also added profiles descriptions and updated URL.
CRAFT-1795
CRAFT-1824