Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove business logic from pack command class #1147

Closed
lengau opened this issue Jul 11, 2023 · 0 comments · Fixed by #1230
Closed

Remove business logic from pack command class #1147

lengau opened this issue Jul 11, 2023 · 0 comments · Fixed by #1230
Assignees
@lengau
Labels
Enhancement New feature or request

Comments

@lengau
Copy link
Collaborator

lengau commented Jul 11, 2023 •
edited
Loading

What needs to get done

The pack command should have its business logic moved into a service class.

Ideally we'd do this with other commands too, but it's absolutely necessary for the pack command.

Why it needs to get done

Precursor for #1133
@lengau lengau changed the title Remove business logic from pack command class Create a pack service and move the pack command to craft-application Jul 13, 2023
@lengau lengau added the Enhancement New feature or request label Aug 8, 2023
@sergiusens sergiusens changed the title Create a pack service and move the pack command to craft-application Remove business logic from pack command class Aug 14, 2023
lengau added a commit that referenced this issue Aug 18, 2023
@lengau
refactor: move builder out of the commands directory.
8369ed4 
Progress on #1147
@lengau lengau mentioned this issue Aug 18, 2023
Merged
lengau added a commit that referenced this issue Aug 18, 2023
@lengau
refactor: move builder out of the commands directory.
32dc35d 
Progress on #1147
lengau added a commit that referenced this issue Aug 19, 2023
@lengau
pack: refactor business logic out of pack command class
da56ef3 
Progress on #1147
@lengau lengau mentioned this issue Aug 19, 2023
Merged
lengau added a commit that referenced this issue Aug 19, 2023
@lengau
pack: refactor business logic out of pack command class
ba078a7 
Progress on #1147
lengau added a commit that referenced this issue Aug 19, 2023
@lengau
pack: refactor business logic out of pack command class
fc5c160 
Progress on #1147
lengau added a commit that referenced this issue Aug 21, 2023
@lengau
refactor: move builder out of the commands directory. (#1229)
f2f423e 
Progress on #1147
lengau added a commit that referenced this issue Aug 21, 2023
@lengau
pack: refactor business logic out of pack command class
11d05a8 
Progress on #1147
lengau added a commit that referenced this issue Aug 22, 2023
@lengau
pack: refactor business logic out of pack command class
18243ce 
Progress on #1147
lengau added a commit that referenced this issue Aug 23, 2023
@lengau
pack: refactor business logic out of pack command class
7117900 
Progress on #1147
lengau added a commit that referenced this issue Aug 25, 2023
@lengau @cmatsuoka
pack: refactor business logic out of pack command class (#1230)
5598434 
Builds on #1229 

Fixes #1147

---------

Co-authored-by: Claudio Matsuoka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lengau lengau

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pack: refactor business logic out of pack command class canonical/charmcraft
1 participant
@lengau