Update dns_record interface to remove service_account #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyandrewmeyer
approved these changes
Dec 2, 2024
6 tasks
|
I don't have the rights to merge this. Can you do it @tonyandrewmeyer ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the last sprint, it was decided to simplify the relation by removing all forms of authentication from it. The ACL part will be done separately in a new charm, the DNS policy charm.
This is an easy change since the relation is not currently used by any charm in production. It will be used by the bind-operator charm, the upcoming dns-policy-operator charm and the dns-integrator-operator charm.
The library is getting updated as part of the following PR: canonical/bind-operator#58