Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed interface tests for tracing v2 #199

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Conversation

PietroPasotti
Copy link
Contributor

@PietroPasotti PietroPasotti commented Nov 15, 2024

the interface tests for tracing v2 are broken.
v2 expects "receivers" to be an object but the tests used to still verify the old v1 behaviour where receivers were plain strings

this PR adjusts that

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tonyandrewmeyer tonyandrewmeyer merged commit f8ad55c into main Dec 1, 2024
7 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the tracing-tests-fix branch December 1, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants