Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Identity and Access Proxy interfaces #112

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Add Identity and Access Proxy interfaces #112

merged 10 commits into from
Dec 1, 2023

Conversation

natalian98
Copy link
Contributor

This PR adds schemas for interfaces making part of Identity and Access Proxy:

  • auth_proxy
  • forward_auth

See IAP interfaces design document for more context.

@natalian98 natalian98 marked this pull request as ready for review October 9, 2023 16:05
@natalian98
Copy link
Contributor Author

natalian98 commented Oct 9, 2023 •
edited
Loading

@simskij @PietroPasotti @gruyaume can you please review? I can't add reviewers on the PR.

gruyaume
gruyaume suggested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@gruyaume gruyaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I got only a couple of minor comments. Also in the future please try to create different PR's for different charm relation interfaces though I understand those 2 are quite related.

interfaces/auth_proxy/v0/README.md Show resolved Hide resolved
interfaces/forward_auth/v0/README.md Outdated Show resolved Hide resolved
interfaces/forward_auth/v0/README.md Outdated Show resolved Hide resolved
interfaces/auth_proxy/v0/schema.py Outdated Show resolved Hide resolved
interfaces/auth_proxy/v0/README.md Outdated Show resolved Hide resolved
@natalian98 natalian98 force-pushed the IAM-557-add-iap-interfaces-to-charm-relation-interfaces branch from 944a4b7 to ac59ea8 Compare October 13, 2023 14:23
@natalian98 natalian98 requested a review from gruyaume October 13, 2023 14:24
@natalian98 natalian98 requested a review from gruyaume October 16, 2023 10:16
@natalian98 natalian98 force-pushed the IAM-557-add-iap-interfaces-to-charm-relation-interfaces branch from b619669 to 223a4ff Compare October 24, 2023 15:48
@natalian98 natalian98 requested a review from jnsgruk October 26, 2023 14:35
@natalian98 natalian98 force-pushed the IAM-557-add-iap-interfaces-to-charm-relation-interfaces branch from 4084a0b to 03d2fc9 Compare December 1, 2023 16:02
@natalian98
Copy link
Contributor Author

Hi @jnsgruk @gruyaume can this PR be merged?

jnsgruk
jnsgruk approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once @gruyaume confirms he's happy with the above requested changes, I'm good for this to be merged!

@gruyaume gruyaume merged commit 2d27d76 into canonical:main Dec 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruyaume gruyaume gruyaume approved these changes

@jnsgruk jnsgruk jnsgruk approved these changes

@simskij simskij Awaiting requested review from simskij

@shipperizer shipperizer Awaiting requested review from shipperizer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natalian98 @jnsgruk @gruyaume