Drop bootstakc-actions #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We decide to not use bootstack-action. Signed-off-by: Robert Gildein <[email protected]>
rgildein
force-pushed
the
chore/no-ref/drop-bootstack-action
branch
from
71fb880
to
594decc
Compare
rgildein
requested review from
Pjack,
aieri,
samuelallan72,
jneo8,
gabrielcocenza,
Deezzir and
chanchiwai-ray
samuelallan72
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Could you use the template from https://github.com/canonical/solutions-engineering-automation/blob/8fc365c874c4e570cce59c8eb3efe92a14b548a5/terraform-plans/templates/github/charm_check.yaml.tftpl#L1 please?
And when this is merged/tested, please add charm_check template to https://github.com/canonical/solutions-engineering-automation/blob/8fc365c874c4e570cce59c8eb3efe92a14b548a5/terraform-plans/configs/charm-duplicity_main.tfvars#L3 . :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decide to not use bootstack-action. I simply copy paste reusable content of reusable workflow here and drop sonnar.
Next step is to add this to solutions-engineering-automation repo.