Skip to content

Commit

Permalink
fix requirements for install hook
Browse files Browse the repository at this point in the history
Fix requirements for install hook not to failed, drop series from
metadata.yaml and drop tmp fix used in chamrcraft.yaml
  • Loading branch information
rgildein committed Apr 15, 2024
1 parent a17ee2e commit e833b26
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
6 changes: 0 additions & 6 deletions charmcraft.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@ parts:
charm:
source: src
plugin: reactive
build-snaps:
# temporary fix because charm cannot install/build on 20.04 using
# charm/3.x without unnecessary dependency in wheelhouse.txt:
# Jinja2<3;python_version == '3.8'
# setuptools~=46.0.0;python_version == '3.8'
- charm/2.x/stable
bases:
- build-on:
- name: ubuntu
Expand Down
1 change: 0 additions & 1 deletion src/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ tags:
# https://jujucharms.com/docs/stable/authors-charm-metadata
- backup
subordinate: true
series: []
provides:
nrpe-external-master:
interface: nrpe-external-master
Expand Down
4 changes: 4 additions & 0 deletions src/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@
croniter
pidfile
fabric
# NOTE(rgildein): The contextvars could not be installed without this requirement to be specified.
setuptools>=42
# NOTE(rgildein): The typing-extensions could not be installed without this requirement to be specified.
flit-core>=3
4 changes: 4 additions & 0 deletions src/wheelhouse.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
distro<1.7.0
croniter
pidfile
# NOTE(rgildein): The contextvars could not be installed without this requirement to be specified.
setuptools>=42
# NOTE(rgildein): The typing-extensions could not be installed without this requirement to be specified.
flit-core>=3

0 comments on commit e833b26

Please sign in to comment.