Run UATs on EKS for v1.8 #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
reviewed
May 28, 2024
There was a problem hiding this comment.
Great job, left some comments. Could you also add in the description that this PR closes also canonical/charmed-kubeflow-uats#55?
Also, should we have a different issue for training-operator since #894 refers specific to k8s 1.28, while it mentions that it succeeds on 1.26.
orfeas-k
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #802 and canonical/charmed-kubeflow-uats#55
The UATs are failing due to and #893
Example execution here: https://github.com/canonical/bundle-kubeflow/actions/runs/9254432418/job/25456220979