Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added config to allow access to internal staging swift #255

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Added config to allow access to internal staging swift #255

merged 1 commit into from
Dec 4, 2024

Conversation

samhotep
Copy link
Member

@samhotep samhotep commented Dec 3, 2024

Done

  • Added staging-swift to $NO_PROXY to allow resolution by the internal k8s DNS
  • Added new secrets on staging that point to the staging-swift instance

QA

  • Check out this feature branch
  • Run the site using the command dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8017

petesfrench
petesfrench approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samhotep samhotep merged commit 708dacb into main Dec 4, 2024
5 checks passed
@samhotep samhotep deleted the add-staging-config branch December 4, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petesfrench petesfrench petesfrench approved these changes

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samhotep @petesfrench