feat: Implement new design for asset cards #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immortalcodes
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Works nicely. I think there are couple of things we could improve here but given we are working towards MVP and will get a more refined design to work with, it's better to work on them later.
I know it's not part of design but the button to get image tag seems necessary if this version is made live at any point of time.
Thanks for the awesome work 🥳
Comment on lines
+1
to
+23
| <div class="p-asset-card p-equal-height-row__col" style=""> | ||
| <div class="p-equal-height-row__item" style="max-height:6rem;"> | ||
| {% if asset.asset_type == "whitepaper" %} | ||
| <img class="p-asset-card--thumbnail" src="https://assets.ubuntu.com/v1/b061c401-White+paper.svg" alt=""> | ||
| {% else %} | ||
| <img class="p-asset-card--thumbnail" src="https://assets.ubuntu.com/v1/fd84bbdc-Document-open.svg" alt=""> | ||
| {% endif %} | ||
| </div> | ||
| <div class="p-equal-height-row__item"> | ||
| {% if asset.name %} | ||
| <p><strong>{{ asset.name }}</strong></p> | ||
| {% else %} | ||
| <p><strong>{{ asset.file_path.split('.')[0] }}</strong></p> | ||
| {% endif %} | ||
| <p class="u-no-margin--bottom">File type: <strong>.{{ asset.file_path.split('.', 1)[1] }}</strong></p> | ||
| <p>Asset type: <strong>{{ asset.asset_type }}</strong></p> | ||
| <p> | ||
| Tags: | ||
| {% for tag in asset.tags %} | ||
| <strong>{{ tag.name }}{% if not loop.last %},{% endif %}</strong> | ||
| {% endfor %} | ||
| </p> | ||
| <p> |
There was a problem hiding this comment.
Just wondering if we could use a single template with some conditions for asset-card and asset-card-image
There was a problem hiding this comment.
I think we should keep them separate for now as we don't know how different they are going to look in the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
/detailsfor a detailed view of each assetQA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-15205