-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement UI for create and update #252
Conversation
If I am right according to specs only non-image assets could have name? |
Definitely not covering all language here. If we want to cover all language we will have to implement something a little more advanced to make it easier to find the appropriate language. But given that this is an MVP, this is fine for now. In the figma it is a multiselect. Why? I do not know haha Edit: I just checked the spec, they actually include a smaller list of languages. But again, this is mvp, so is likely fine |
For the tags section, I am not sure the proper UX pattern follow here. The figma said to use search and filter, but there is nothing to search so I tried to adapt it. I will ask @Sophie-32 tomorrow. For the non-image asset not having names, where can you see this in the spec? I don't see why we would do that. For failed base64 encoding, I have hopefully fixed this in the next PR For the second tags comments, this again related to the UX of how it should work. Will address tomorrow with Sophie's input. For redirecting after editing, yes this is temporary until we have a 'details' page. Which is being added in the next PR. |
Makes sense, for the name thing here is the comment that says add name if it's a PDF. Not sure if this is valid for all. |
There are few things that are still in discussion and might need correction later(with more clarity from design and UX), We could also plan a bit of refactoring in later stages, but this is really good work and checks everything for MVP. |
Done
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-13751