-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new fields to create & update api's #250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petesfrench
changed the title
WIP feat: Add new fields to create & update api's
feat: Add new fields to create & update api's
Oct 11, 2024
petesfrench
requested review from
immortalcodes
and removed request for
akbarkz
October 18, 2024 06:47
immortalcodes
requested changes
Oct 18, 2024
Also are we not removing the GET method? |
immortalcodes
added
Review: QA -1
Review: Code +1 (with changes)
and removed
Review: Code needed
Review: QA needed
labels
Oct 21, 2024
I believe you have to pass the file-name in the url like this: http://0.0.0.0:8017/manager/update?file-path=FILE_NAME @immortalcodes |
immortalcodes
approved these changes
Oct 21, 2024
Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
name
author
asset_type
google_drive_link
salesforce_campaign_id
language
products
QA
Using postman
You can create an asset with a POST request to 'http://0.0.0.0:8017/manager/create'
You can copy this into the 'bulk edit' tab within 'body'. You just need to manually add a file:
You can edit an asset with a POST request to http://0.0.0.0:8017/manager/update?file-path=FILE_NAME. You can use the same 'bulk edit as above and adjust some values.
To check I would just make a GET request to http://0.0.0.0:8017/v1 to list all assets, it should be the last in the list
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-15204