refactor: Apply changes from review

canonical · Nov 8, 2024 · 2789ee4 · 2789ee4
1 parent 67c6233
commit 2789ee4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/static/js/src/authors-search.js b/static/js/src/authors-search.js
@@ -16,7 +16,7 @@ const updateQueryParams = document.querySelector('.js-asset-search');
 (function () {
   const authorsSearchComponent = document.querySelector('.js-authors-search');
   if (authorsSearchComponent) {
-    authorsSearchComponent?.addEventListener('focusin', function (e) {
+    authorsSearchComponent.addEventListener('focusin', function () {
       openPanel(authorsSearchComponent, true, 'focusin');
     });
     authorsSearchComponent.addEventListener('focusout', function (e) {
@@ -45,8 +45,6 @@ function setUpAuthorSearchField() {
         if (response.ok) {
           const data = await response.json();
           updateSearchResults(data);
-        } else {
-          console.log("No user found");
         }
       } catch (error) {
         console.error('Error fetching user data:', error);
@@ -73,7 +71,7 @@ export default function handleAuthorsChip(targetChip) {
 
 /*
  * Adds and removes the author chips to the search panel.
- * As this comes from an API call, we can not setupo the chips on load (like with products).
+ * As this comes from an API call, we can not setup the chips on load (like with products).
  * We have to create the chips on the fly. Limited to 10 results.
  * @param {Array} data - The data from the API call.
  **/

diff --git a/static/js/src/date-picker.js b/static/js/src/date-picker.js
@@ -6,7 +6,7 @@ document.addEventListener("DOMContentLoaded", function () {
   flatpickr(".js-date-picker", {
     mode: "range",
     dateFormat: "Y-m-d",
-    onChange: function(selectedDates, dateStr, instance) {
+    onChange: function(selectedDates) {
       const [startDate, endDate] = selectedDates;
       if (startDate) {
         addValueToHiddenInput(startDate.toISOString(), document.querySelector(".js-hidden-field-startdate"), replace = true);

diff --git a/static/js/src/generic-fields.js b/static/js/src/generic-fields.js
@@ -39,7 +39,7 @@ function handleSelectInputs() {
  */
 function handleTagInput() {
   const tagsInput = document.querySelector('.js-tags');
-  tagsInput?.addEventListener('input', function(e) {
+  tagsInput?.addEventListener('input', function() {
     addValueToQueryParams(tagsInput.name, tagsInput.value, replace = true);
   });
 }
@@ -49,7 +49,7 @@ function handleTagInput() {
  */
 function handleSalesforceIdInput() {
   const salesforceIdInput = document.querySelector('.js-salesforce-campaign-id');
-  salesforceIdInput?.addEventListener('input', function(e) {
+  salesforceIdInput?.addEventListener('input', function() {
     addValueToQueryParams(salesforceIdInput.name, salesforceIdInput.value, replace = true);
   });
 }