Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pin deployed charms to a CKF 1.8 compatible version #163

Merged
merged 6 commits into from
Apr 16, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Apr 11, 2024

This commit pins all charms that get deployed from Charmhub to a compatible version to the CKF 1.8 release.

Part of canonical/bundle-kubeflow#863

@DnPlas DnPlas requested a review from a team as a code owner April 11, 2024 13:00
This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
@DnPlas DnPlas force-pushed the KF-5537-pin-charm-deps-in-track branch from 46f2c45 to cd328d3 Compare April 11, 2024 13:05
@DnPlas
Copy link
Contributor Author

DnPlas commented Apr 15, 2024

The publishing job is failing due to #150, but tests (lint, integration and unit) must pass.

Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the changes and looks right. LGTM

@DnPlas DnPlas merged commit cc88df1 into track/3.3.10 Apr 16, 2024
11 of 12 checks passed
@DnPlas DnPlas deleted the KF-5537-pin-charm-deps-in-track branch April 16, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants