report: use library search order from ld.so #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
+ Coverage 83.00% 83.01% +0.01%
==========================================
Files 99 99
Lines 20333 20352 +19
Branches 3212 3218 +6
==========================================
+ Hits 16877 16896 +19
+ Misses 2936 2935 -1
- Partials 520 521 +1 ☔ View full report in Codecov by Sentry. |
schopin-pro
requested changes
Jun 21, 2024
apport/report.py
Outdated
| f":{gdb_sandbox}/lib/{native_multiarch}" | ||
| f":{gdb_sandbox}/usr/lib/{native_multiarch}" | ||
| f"{gdb_sandbox}/lib" |
There was a problem hiding this comment.
issue: Rather than a hardcoded list, shouldn't we actually query the local ld.so to get the search order?
There was a problem hiding this comment.
You asked for it. Now you get a bigger merge request!
bdrung
force-pushed
the
lib-search-order
branch
3 times, most recently
from
7e9693b to
9887383
Compare
|
Problem with the implementation: jammy does not ship |
|
I didn't even remember that |
bdrung
force-pushed
the
lib-search-order
branch
from
2298507 to
4b142e3
Compare
The library search order from `ld.so` differs from the hard-coded list: ``` $ ld.so --help [...] Shared library search path: (libraries located via /etc/ld.so.cache) /lib/x86_64-linux-gnu (system search path) /usr/lib/x86_64-linux-gnu (system search path) /lib (system search path) /usr/lib (system search path) ``` So determine the library search paths dynamically from `ld.so`. Signed-off-by: Benjamin Drung <[email protected]>
bdrung
force-pushed
the
lib-search-order
branch
from
4b142e3 to
813fb4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same library search order from
ld.so: