add links for deprecated docs #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
approved these changes
Apr 2, 2019
docs/keys/scope.vars.md
Outdated
| @@ -2,6 +2,8 @@ | |||
| @parent can-stache/deprecated | |||
| @description Used to reference variables specific to the template context | |||
|
|
|||
| @deprecated {4.15.0} Use `{{ let }}` [can-stache.helpers.let]. instead. | |||
There was a problem hiding this comment.
[can-stache.helpers.let]. instead. -> [can-stache.helpers.let] instead. (extra period)
docs/tags/partial.md
Outdated
| @@ -1,6 +1,8 @@ | |||
| @function can-stache.tags.partial {{>key}} | |||
| @parent can-stache/deprecated | |||
|
|
|||
| @deprecated {4.15} Use passing renderer functions through the ViewModel instead. | |||
There was a problem hiding this comment.
Do we have docs anywhere on this? It’d be nice to add a link.
There was a problem hiding this comment.
@chasenlehara I can not find a link that talks about renderer functions through the ViewModel instead., should we document it?
There was a problem hiding this comment.
I would change this sentence to say something like:
@deprecated {4.15} Pass renderer functions through the ViewModel instead. See the “Calling views” section in the [can-stache#BasicUse can-stache docs] for an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For canjs/canjs#4709
This adds
@deprecatedmessage on the pages for deprecated feature and and links to what should be used instead.If you find that missed something in the message or add put wrong version, please let me know.