fix: add image cache for Android

candlefinance · May 13, 2024 · c199b51 · c199b51
1 parent 9971991
commit c199b51
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 16 deletions.
diff --git a/android/src/main/java/com/candlefinance/fasterimage/FasterImagePackage.kt b/android/src/main/java/com/candlefinance/fasterimage/FasterImagePackage.kt
@@ -8,7 +8,7 @@ import com.facebook.react.uimanager.ViewManager
 
 class FasterImagePackage : ReactPackage {
   override fun createNativeModules(reactContext: ReactApplicationContext): List<NativeModule> {
-    return emptyList()
+    return listOf(FasterImageModule(reactContext))
   }
 
   override fun createViewManagers(reactContext: ReactApplicationContext): List<ViewManager<*, *>> {

diff --git a/android/src/main/java/com/candlefinance/fasterimage/FasterImageViewManager.kt b/android/src/main/java/com/candlefinance/fasterimage/FasterImageViewManager.kt
@@ -12,21 +12,36 @@ import android.view.View
 import android.view.ViewOutlineProvider
 import android.widget.ImageView.ScaleType
 import androidx.appcompat.widget.AppCompatImageView
-  import coil.annotation.ExperimentalCoilApi
-  import coil.imageLoader
+import coil.annotation.ExperimentalCoilApi
+import coil.imageLoader
 import coil.request.CachePolicy
 import coil.request.ImageRequest
 import coil.size.Scale
 import com.facebook.react.bridge.Arguments
 import com.facebook.react.bridge.Promise
+import com.facebook.react.bridge.ReactApplicationContext
 import com.facebook.react.bridge.ReactContext
+import com.facebook.react.bridge.ReactContextBaseJavaModule
 import com.facebook.react.bridge.ReactMethod
 import com.facebook.react.bridge.ReadableMap
 import com.facebook.react.uimanager.SimpleViewManager
 import com.facebook.react.uimanager.ThemedReactContext
 import com.facebook.react.uimanager.annotations.ReactProp
 import com.facebook.react.uimanager.events.RCTEventEmitter
 
+  @Suppress("unused")
+  class FasterImageModule(reactContext: ReactApplicationContext) : ReactContextBaseJavaModule(reactContext) {
+    override fun getName(): String = "FasterImageModule"
+
+    @OptIn(ExperimentalCoilApi::class)
+    @ReactMethod
+    fun clearCache(promise: Promise) {
+      val imageLoader = reactApplicationContext.imageLoader
+      imageLoader.memoryCache?.clear()
+      imageLoader.diskCache?.clear()
+      promise.resolve(true)
+    }
+  }
 
   class FasterImageViewManager : SimpleViewManager<AppCompatImageView>() {
     override fun getName() = "FasterImageView"
@@ -175,15 +190,6 @@ import com.facebook.react.uimanager.events.RCTEventEmitter
         return intArray
       }
 
-     @OptIn(ExperimentalCoilApi::class)
-     @ReactMethod
-      fun clearCache(view: AppCompatImageView, promise: Promise) {
-        val imageLoader = view.context.imageLoader
-       imageLoader.memoryCache?.clear()
-        imageLoader.diskCache?.clear()
-        promise.resolve(null)
-      }
-
     companion object {
       private val RESIZE_MODE = mapOf(
         "contain" to ScaleType.FIT_CENTER,

diff --git a/example/src/App.tsx b/example/src/App.tsx
@@ -2,12 +2,12 @@ import * as React from 'react';
 
 import { FasterImageView, clearCache } from '@candlefinance/faster-image';
 import {
+  DevSettings,
   Dimensions,
   FlatList,
   Platform,
   SafeAreaView,
   StyleSheet,
-  DevSettings,
 } from 'react-native';
 
 const size = Dimensions.get('window').width / 3;
@@ -19,7 +19,7 @@ const imageURLs = Array.from(
 if (__DEV__ && Platform.OS === 'ios') {
   DevSettings.addMenuItem('Clear Cache', async () => {
     const result = await clearCache();
-    console.log(result);
+    console.log('cache cleared', result);
   });
 }
 

diff --git a/src/index.tsx b/src/index.tsx
@@ -111,6 +111,11 @@ export const FasterImageView =
   requireNativeComponent<FasterImageProps>(ComponentName);
 
 export const clearCache = async () => {
-  const { FasterImageViewManager } = NativeModules;
-  return FasterImageViewManager.clearCache();
+  if (Platform.OS === 'ios') {
+    const { FasterImageViewManager } = NativeModules;
+    return FasterImageViewManager.clearCache();
+  } else {
+    const { FasterImageModule } = NativeModules;
+    return FasterImageModule.clearCache();
+  }
 };