Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/convert to json #70

Merged
merged 20 commits into from
Jul 13, 2021
Merged

Feature/convert to json #70

merged 20 commits into from
Jul 13, 2021

Conversation

davidrajones
Copy link
Contributor

No description provided.

Copy link
Contributor

@keiranmraine keiranmraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to check over, otherwise it's good

perl/bin/alleleCounterToJson.pl Outdated Show resolved Hide resolved
'h|help' => \$opts{'h'},
'l|locus-file=s' => \$opts{'l'},
'a|allelecount-file=s' => \$opts{'a'},
'o|output-file=s' => \$opts{'o'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=s means the option is required, while :s means optional. I'm not convinced it makes that much difference more an indicator of intent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected

@davidrajones davidrajones merged commit 12af841 into dev Jul 13, 2021
@davidrajones davidrajones deleted the feature/convert_to_json branch July 13, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants