-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/convert to json #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things to check over, otherwise it's good
perl/bin/alleleCounterToJson.pl
Outdated
'h|help' => \$opts{'h'}, | ||
'l|locus-file=s' => \$opts{'l'}, | ||
'a|allelecount-file=s' => \$opts{'a'}, | ||
'o|output-file=s' => \$opts{'o'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=s
means the option is required, while :s
means optional. I'm not convinced it makes that much difference more an indicator of intent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected
…ature/convert_to_json
No description provided.