Fix keySystems option changing when reusing MediaKeySystemAccess #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed yet another bug while continuing to add DRM integration tests thanks to #1478. If the `keySystems` `loadVideo` option was subtly modified between loadVideo calls, yet if we reused the same cached `MediaKeySystemAccess` we risked to rely on the old `keySystems` option, not on the new one. It seems this bug was always there, so it shouldn't impact much applications? But it seems relatively important to me.
peaBerberian
added
bug
peaBerberian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed yet another bug while continuing to add DRM integration tests thanks to #1478.
If the
keySystemsloadVideooption was subtly modified between loadVideo calls, yet if we reused the same cachedMediaKeySystemAccesswe risked to rely on the oldkeySystemsoption, not on the new one.It seems this bug was always there, so it shouldn't have impacted much applications (we would have heard of it)? But it seems relatively important to me.
I saw that issue in my integration tests while playing with the
serverCertificateoption. Changing it without changing the key system betweenloadVideocalls weirdly resulted in the firstserverCertificatebeing used instead.