-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to set a new keySystems
option on the reload
API
#1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
added
DRM
Relative to DRM (EncryptedMediaExtensions)
API
Relative to the RxPlayer's API
Priority: 1 (High)
This issue or PR has a high priority.
labels
Nov 2, 2023
A majority of the bigger issues we encounter in production is DRM-related, leading us to either work-around those in the RxPlayer, or to facilitate a work-around on the application-side through a better DRM-related API. Recently, we've seen that many Windows/Edge users (but still a minority of them) could encounter an issue on the `generateRequest` EME call when relying on PlayReady SL3000 (hardware-backed decryption and playback, seen as one the most secure DRM mechanism for OTT contents) which would lead to a failure to play the content. When this happens, fallbacking to a different key system like PlayReady SL2000 (where decryption happens in software) or Widevine usually (though not always) seems to avoid the issue, even if it might lead to less protection and thus might lead generally to only lower video qualities (as higher security requirements are in practice generally just enforced for the higher video qualities, depending on license policies). After brainstorming whether this fallback should be done on the RxPlayer-side, or on the application-side, we're for now implementing the easier way (for us :p) of just providing here an API allowing to just let the application replay the last loaded content (whose loading may have failed due to the aforementioned `generateRequest` error) with a different `keySystems` configuration, thus allowing an application to reload the last loaded content after blacklisting the current key system if the error appears to be linked to that issue.
peaBerberian
force-pushed
the
feat/reload-keySystems
branch
from
November 14, 2023 11:47
4d2d94c
to
6ee2433
Compare
Florent-Bouisset
approved these changes
Nov 14, 2023
peaBerberian
added a commit
that referenced
this pull request
Nov 14, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Nov 14, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Nov 23, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Nov 23, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Nov 23, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 4, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 4, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 4, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 5, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 5, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 5, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 5, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 7, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 7, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 19, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 19, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 20, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 20, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 22, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 22, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Dec 22, 2023
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 3, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 3, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 3, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 3, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 3, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add the possibility to set a new `keySystems` option on the `reload` API
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
API
Relative to the RxPlayer's API
DRM
Relative to DRM (EncryptedMediaExtensions)
Priority: 1 (High)
This issue or PR has a high priority.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A majority of the bigger issues we encounter in production is DRM-related, leading us to either work-around those in the RxPlayer, or to facilitate a work-around on the application-side through a better DRM-related API.
Recently, we've seen that many Windows/Edge users (but still a minority of them) could encounter an issue on the
generateRequest
EME call when relying on PlayReady SL3000 (hardware-backed decryption and playback, seen as one the most secure DRM mechanism for OTT contents) which would lead to a failure to play the content.When this happens, fallbacking to a different key system like PlayReady SL2000 (where decryption happens in software) or Widevine usually (though not always) seems to avoid the issue, even if it might lead to less protection and thus might lead generally to only lower video qualities (as higher security requirements are in practice generally just enforced for the higher video qualities, depending on license policies).
After brainstorming whether this fallback should be done on the RxPlayer-side, or on the application-side, we're for now implementing the easier way (for us :p) of just providing here an API allowing to just let the application replay the last loaded content (whose loading may have failed due to the aforementioned
generateRequest
error) with a differentkeySystems
configuration, thus allowing an application to reload the last loaded content after blacklisting the current key system if the error appears to be linked to that issue.