Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): compose command wasnt properly parsed #147

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix(test): compose command wasnt properly parsed #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/compose/healthy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Edge case; Self-hosted runners don't support "docker compose" yet even though on v2
VERSION=$(docker-compose version --short)

if [[ "$VERSION" =~ ^1\.[0-9]+\.[0-9]+ ]]; then
if [[ "$VERSION" =~ ^1\.[0-9]+\.[0-9]+ || -z "${VERSION}" ]]; then
# if docker-compose is v1, we're setting it to docker compose, which should be v2
echo "Deteceted v1, setting to v2"
DOCKER_COMMAND="docker compose -f ${FILE} ${COMPOSE_FLAGS}"
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/build-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ jobs:

notify-on-failure:
runs-on: ubuntu-latest
if: failure()
if: failure() && github.event_name == 'schedule'
needs:
- publish-image
- read-build-image-output
Expand All @@ -543,7 +543,6 @@ jobs:
steps:
- name: Notify in Slack in case of failure
id: slack-notification
if: github.event_name == 'schedule'
uses: camunda/infraex-common-config/.github/actions/report-failure-on-slack@44ea6ed8c70214b8ef629c292ae0e84710179633 # main
with:
vault_addr: ${{ secrets.VAULT_ADDR }}
Expand Down