feat(webhook): Add support for document upload #3659
Draft
+375
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
force-pushed
the
788-file-upload-support-for-the-webhook-connector
branch
from
c49c998
to
55f050f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...in/java/io/camunda/connector/runtime/core/inbound/correlation/InboundCorrelationHandler.java
Dismissed
Show dismissed
Hide dismissed
...src/main/java/io/camunda/connector/runtime/inbound/webhook/InboundWebhookRestController.java
Dismissed
Show dismissed
Hide dismissed
sbuettner
reviewed
Nov 18, 2024
| @@ -101,6 +96,11 @@ public InboundConnectorContextImpl( | |||
| logs); | |||
| } | |||
|
|
|||
| @Override | |||
| public ActivationCheckResult canActivate(Object variables) { | |||
There was a problem hiding this comment.
What about ActivationResult?
There was a problem hiding this comment.
We discussed that with the team and came up with this name, as we are not activating anything. ActivationResult might be a bit misleading in that regard
There was a problem hiding this comment.
I see, although we activate without correlate. 😄
sbuettner
reviewed
Nov 18, 2024
| @@ -128,9 +137,12 @@ private ResponseEntity<?> processWebhook( | |||
| // when verification was skipped | |||
| // Step 2: trigger and correlate | |||
| var webhookResult = connectorHook.triggerWebhook(payload); | |||
| var ctxData = toWebhookTriggerResultContext(webhookResult); | |||
| // create documents if the connector is activable | |||
| var documentReferences = createDocuments(connector.context(), payload); | |||
There was a problem hiding this comment.
How do we deal with errors during createDocuments? Will the exceptions just bubble up?
sbuettner
reviewed
Nov 18, 2024
Comment on lines
+19
to
+33
| public sealed interface ActivationCheckResult { | ||
|
|
||
| sealed interface Success extends ActivationCheckResult { | ||
| ProcessElementContext activatedElement(); | ||
|
|
||
| record CanActivate(ProcessElementContext activatedElement) implements Success {} | ||
| } | ||
|
|
||
| sealed interface Failure extends ActivationCheckResult { | ||
|
|
||
| record NoMatchingElement(boolean discardUnmatchedEvents) implements Failure {} | ||
|
|
||
| record TooManyMatchingElements() implements Failure {} | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice type hierarchy and model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #
Checklist
no milestonelabel.