-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
others(operate-importer): add more logs during the import of process definitions #3512
others(operate-importer): add more logs during the import of process definitions #3512
Conversation
@chillleader Can you please take a look whether these log statements would help? It wasnt clear to me based on the ticket whether trace/debug will help as they are usually not shown using the default log levels. |
From my understanding, when a lot of process are present, this can take lots of time, as we use the operate client to retrieve all of them page by page, then sorting, then filtering out etc.. |
@mathias-vandaele If we want to get more information about "where we are in the process" we would benefit from some kind of "progress" or number of pages we already scanned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chillleader Can you please take a look whether these log statements would help? It wasnt clear to me based on the ticket whether trace/debug will help as they are usually not shown using the default log levels.
I think these changes will be helpful - although they are not shown by default due to logging level (only info and above are shown), it's quite easy to increase the logging level if we want to gain access to this info. I was originally looking for some progress indication, as well as a way to know which process IDs are being processed - I think this PR solves this well.
The only suggestion from my side: I'd rather keep all detailed log entries under the DEBUG
or INFO
level (depending on whether we want to show them by default) and not introduce the TRACE
level to keep things a little less complicated
I will change the trace into debug 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…definitions (#3512) * others(operate-importer): add more logs during the import of process definitions * others(logs): format files * others(logs): format files 2 and remove trace logs
…definitions (#3512) * others(operate-importer): add more logs during the import of process definitions * others(logs): format files * others(logs): format files 2 and remove trace logs
…definitions (#3512) * others(operate-importer): add more logs during the import of process definitions * others(logs): format files * others(logs): format files 2 and remove trace logs
Adding logs during the importation of process definitions
Description
This PR add logs tracing what is happening during the importation of the process definition from Operate.
Related issues
closes #3190
Checklist
no milestone
label.