fix(email-inbound-connector): implement a reconnect and reopen mechanism #3506

mathias-vandaele · 2024-10-16T15:25:56Z

Description

As asked by @sbuettner this PR implements a re connect / re open mechanism

Related issues

closes #

Checklist

PR has a milestone or the no milestone label.

… for folder creation, and add unit tests

sbuettner · 2024-10-24T08:59:55Z

...rs/email/src/main/java/io/camunda/connector/email/client/jakarta/inbound/PollingManager.java

+      try {
+        this.jakartaUtils.connectStore(store, authentication);
+      } catch (MessagingException e) {
+        throw new RuntimeException("Could not reconnect to store");


Can you add the exception to the log so we can find out what failed?

sbuettner · 2024-10-24T09:00:04Z

...rs/email/src/main/java/io/camunda/connector/email/client/jakarta/inbound/PollingManager.java

+      try {
+        this.folder.open(Folder.READ_WRITE);
+      } catch (MessagingException e) {
+        throw new RuntimeException("Could not reopen folder");


same as above

sbuettner · 2024-10-24T09:00:27Z

...main/java/io/camunda/connector/email/client/jakarta/outbound/JakartaEmailActionExecutor.java

@@ -130,7 +130,7 @@ private MoveEmailResponse imapMoveEmails(
      sourceImapFolder.open(Folder.READ_WRITE);
      Folder targetImapFolder =
          store.getFolder(
-              String.join(String.valueOf(rootFolder.getSeparator()), toFolder.split("\\.")));
+              String.join(String.valueOf(rootFolder.getSeparator()), toFolder.split("[./]")));


Can we use a constant for this.

sbuettner · 2024-10-24T09:01:05Z

...ectors/email/src/main/java/io/camunda/connector/email/client/jakarta/utils/JakartaUtils.java

@@ -321,7 +321,7 @@ public void moveMessage(Store store, Message message, String targetFolder) {
      char separator = imapFolder.getSeparator();
      String targetFolderFormatted =
          Optional.ofNullable(targetFolder)
-              .map(string -> string.split("\\."))
+              .map(string -> string.split("[./]"))


... and use this constant here as well?

Or create a simple static method for this logic. Would be even better

sbuettner · 2024-10-24T09:01:38Z

...ectors/email/src/main/java/io/camunda/connector/email/client/jakarta/utils/JakartaUtils.java

@@ -321,7 +321,7 @@ public void moveMessage(Store store, Message message, String targetFolder) {
      char separator = imapFolder.getSeparator();
      String targetFolderFormatted =
          Optional.ofNullable(targetFolder)
-              .map(string -> string.split("\\."))
+              .map(string -> string.split("[./]"))
              .map(strings -> String.join(String.valueOf(separator), strings))
              .orElse("temp");


I think we dont need this fallback.

… for folder creation, and add unit tests 2

johnBgood · 2024-10-24T15:28:34Z

...ectors/email/src/main/java/io/camunda/connector/email/client/jakarta/utils/JakartaUtils.java

              .map(strings -> String.join(String.valueOf(separator), strings))
-              .orElse("temp");
+              .orElseThrow(() -> new RuntimeException("No folder has been set"));


Suggested change

.orElseThrow(() -> new RuntimeException("No folder has been set"));

.orElseThrow(() -> new RuntimeException("No target folder has been set"));

johnBgood

🔥

sbuettner · 2024-10-25T14:58:29Z

Backport failed for release/8.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.6
git worktree add -d .worktree/backport-3506-to-release/8.6 origin/release/8.6
cd .worktree/backport-3506-to-release/8.6
git switch --create backport-3506-to-release/8.6
git cherry-pick -x be06a0ee548f5049437bf24b54b2e730cdf1c582

…ism (#3506) * fix(email-inbound-connector): implement a reconnect and reopen mechanism * fix(email-connectors): add equalsIgnoreCase for INBOX * fix(email-inbound-connector): add integration tests, modify the split for folder creation, and add unit tests * fix(email-inbound-connector): add integration tests, modify the split for folder creation, and add unit tests 2

mathias-vandaele · 2024-10-28T15:54:14Z

/backport

sbuettner · 2024-10-28T15:54:29Z

Backport failed for release/8.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.6
git worktree add -d .worktree/backport-3506-to-release/8.6 origin/release/8.6
cd .worktree/backport-3506-to-release/8.6
git switch --create backport-3506-to-release/8.6
git cherry-pick -x be06a0ee548f5049437bf24b54b2e730cdf1c582

…ism (#3506) * fix(email-inbound-connector): implement a reconnect and reopen mechanism * fix(email-connectors): add equalsIgnoreCase for INBOX * fix(email-inbound-connector): add integration tests, modify the split for folder creation, and add unit tests * fix(email-inbound-connector): add integration tests, modify the split for folder creation, and add unit tests 2 (cherry picked from commit be06a0e)

…ism (#3506) * fix(email-inbound-connector): implement a reconnect and reopen mechanism * fix(email-connectors): add equalsIgnoreCase for INBOX * fix(email-inbound-connector): add integration tests, modify the split for folder creation, and add unit tests * fix(email-inbound-connector): add integration tests, modify the split for folder creation, and add unit tests 2

mathias-vandaele requested a review from a team as a code owner October 16, 2024 15:25

mathias-vandaele self-assigned this Oct 17, 2024

mathias-vandaele added backport release/8.6 deploy-preview labels Oct 17, 2024

github-actions bot temporarily deployed to connectors-email-inbound-c-c8sm October 22, 2024 09:51 Destroyed

github-actions bot temporarily deployed to connectors-email-inbound-c-c8sm October 22, 2024 10:21 Destroyed

mathias-vandaele added 2 commits October 22, 2024 12:23

fix(email-inbound-connector): implement a reconnect and reopen mechanism

ab1a31e

fix(email-connectors): add equalsIgnoreCase for INBOX

7bc2c81

mathias-vandaele force-pushed the email-inbound-connector-add-reconnection-mechanism branch from b0c267a to 7bc2c81 Compare October 22, 2024 10:23

github-actions bot temporarily deployed to connectors-email-inbound-c-c8sm October 22, 2024 10:23 Destroyed

github-actions bot temporarily deployed to connectors-email-inbound-c-c8sm October 22, 2024 12:02 Destroyed

fix(email-inbound-connector): add integration tests, modify the split…

027eb35

… for folder creation, and add unit tests

github-actions bot temporarily deployed to connectors-email-inbound-c-c8sm October 23, 2024 14:51 Destroyed

johnBgood modified the milestones: 8.7.0-alpha1, 8.6.3 Oct 24, 2024

sbuettner reviewed Oct 24, 2024

View reviewed changes

fix(email-inbound-connector): add integration tests, modify the split…

344753d

… for folder creation, and add unit tests 2

github-actions bot temporarily deployed to connectors-email-inbound-c-c8sm October 24, 2024 15:11 Destroyed

johnBgood reviewed Oct 24, 2024

View reviewed changes

johnBgood approved these changes Oct 24, 2024

View reviewed changes

mathias-vandaele added this pull request to the merge queue Oct 25, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 25, 2024

mathias-vandaele added this pull request to the merge queue Oct 25, 2024

Merged via the queue into main with commit be06a0e Oct 25, 2024
11 checks passed

mathias-vandaele deleted the email-inbound-connector-add-reconnection-mechanism branch October 25, 2024 14:58

mathias-vandaele mentioned this pull request Oct 28, 2024

fix(email-inbound-connector): implement a reconnect and reopen mechan… #3547

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(email-inbound-connector): implement a reconnect and reopen mechanism #3506

fix(email-inbound-connector): implement a reconnect and reopen mechanism #3506

mathias-vandaele commented Oct 16, 2024 •

edited by johnBgood

Loading

sbuettner Oct 24, 2024

sbuettner Oct 24, 2024

sbuettner Oct 24, 2024

sbuettner Oct 24, 2024

sbuettner Oct 24, 2024

johnBgood Oct 24, 2024

johnBgood left a comment

sbuettner commented Oct 25, 2024

mathias-vandaele commented Oct 28, 2024

sbuettner commented Oct 28, 2024

	.orElseThrow(() -> new RuntimeException("No folder has been set"));
	.orElseThrow(() -> new RuntimeException("No target folder has been set"));

fix(email-inbound-connector): implement a reconnect and reopen mechanism #3506

fix(email-inbound-connector): implement a reconnect and reopen mechanism #3506

Conversation

mathias-vandaele commented Oct 16, 2024 • edited by johnBgood Loading

Description

Related issues

Checklist

sbuettner Oct 24, 2024

Choose a reason for hiding this comment

sbuettner Oct 24, 2024

Choose a reason for hiding this comment

sbuettner Oct 24, 2024

Choose a reason for hiding this comment

sbuettner Oct 24, 2024

Choose a reason for hiding this comment

sbuettner Oct 24, 2024

Choose a reason for hiding this comment

johnBgood Oct 24, 2024

Choose a reason for hiding this comment

johnBgood left a comment

Choose a reason for hiding this comment

sbuettner commented Oct 25, 2024

mathias-vandaele commented Oct 28, 2024

sbuettner commented Oct 28, 2024

mathias-vandaele commented Oct 16, 2024 •

edited by johnBgood

Loading