Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview-environments): Adapt to C8 Helm chart v11 #3499

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

maxdanilov
Copy link
Member

@maxdanilov maxdanilov commented Oct 16, 2024

Description

fix(preview-environments): Adapt to C8 Helm chart v11

The preview environments code has recently been upgraded to use Helm charts v11 (#3476), but no corresponding follow-up adjustments have been done to the code to conform to it (breaking changes in v10, v11)

  • The separate Camunda-developed Identity subchart is not existent since v10 and has been integrated natively into the chart
  • identity.keycloak became identityKeycloak (ref)
  • elasticsearch.host is now elasticsearch.url.host
  • zeebe-gateway became zeebeGateway

Related issues

Related: https://camunda.slack.com/archives/C5AHF1D8T/p1728980290646239

closes #

Checklist

  • PR has a milestone or the no milestone label.

@maxdanilov maxdanilov requested a review from a team as a code owner October 16, 2024 12:20
@maxdanilov maxdanilov self-assigned this Oct 16, 2024
@maxdanilov maxdanilov marked this pull request as draft October 16, 2024 12:20
@maxdanilov
Copy link
Member Author

This is WIP, not to be reviewed yet.

@maxdanilov maxdanilov force-pushed the preview-enrivonments-fix branch 2 times, most recently from bd615e6 to 0cc2298 Compare October 16, 2024 12:55
@github-actions github-actions bot temporarily deployed to connectors-preview-enrivon-c8sm October 16, 2024 13:02 Destroyed
@maxdanilov maxdanilov marked this pull request as ready for review October 17, 2024 13:54
@sbuettner
Copy link
Contributor

I tested the environment and was able to create, deploy and executed a process successfully.

@maxdanilov maxdanilov added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@sbuettner sbuettner added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@sbuettner sbuettner added this pull request to the merge queue Oct 17, 2024
@maxdanilov
Copy link
Member Author

maxdanilov commented Oct 17, 2024

@sbuettner does it make sense to rebase this branch? the following error pops-up in the run workflow, not related to the changes here:

[FATAL] Non-resolvable parent POM for io.camunda.connector:connectors-e2e-test-mail:8.6.0-SNAPSHOT: Could not find artifact io.camunda.connector:connectors-e2e-test-parent:pom:8.6.0-SNAPSHOT and 'parent.relativePath' points at wrong local POM @ line 5, column 13
 @ 

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@github-actions github-actions bot temporarily deployed to connectors-preview-enrivon-c8sm October 17, 2024 14:39 Destroyed
@maxdanilov maxdanilov added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 0434243 Oct 17, 2024
11 checks passed
@maxdanilov maxdanilov deleted the preview-enrivonments-fix branch October 17, 2024 15:37
mathias-vandaele pushed a commit that referenced this pull request Oct 25, 2024
* fix(preview-environments): Adapt to C8 Helm chart v11

Related: https://camunda.slack.com/archives/C5AHF1D8T/p1728980290646239

* fix(preview-environments): Fix the deprecated Helm chart key names
mathias-vandaele pushed a commit that referenced this pull request Oct 28, 2024
* fix(preview-environments): Adapt to C8 Helm chart v11

Related: https://camunda.slack.com/archives/C5AHF1D8T/p1728980290646239

* fix(preview-environments): Fix the deprecated Helm chart key names
mathias-vandaele pushed a commit that referenced this pull request Oct 28, 2024
* fix(preview-environments): Adapt to C8 Helm chart v11

Related: https://camunda.slack.com/archives/C5AHF1D8T/p1728980290646239

* fix(preview-environments): Fix the deprecated Helm chart key names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants