feat(idp extraction connector): implement new idp extraction outbound connector #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java
Fixed
Show fixed
Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java
Fixed
Show fixed
Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java
Fixed
Show fixed
Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java
Fixed
Show fixed
Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java
Fixed
Show fixed
Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java
Fixed
Show fixed
Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java
Fixed
Show fixed
Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java
Fixed
Show fixed
Hide fixed
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java
Fixed
Show fixed
Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java
Fixed
Show fixed
Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java
Fixed
Show fixed
Hide fixed
...ectors/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/utils/AwsS3Util.java
Fixed
Show fixed
Hide fixed
sbuettner
reviewed
Oct 16, 2024
| import org.apache.commons.lang3.builder.EqualsBuilder; | ||
| import org.apache.commons.lang3.builder.HashCodeBuilder; | ||
|
|
||
| public class ExtractionRequest extends AwsBaseRequest { |
There was a problem hiding this comment.
To be more flexible in terms of cloud providers, I would recommend to create another class in your model like AwsRequest and just reference it ExtractionRequest so you dont have to inherit from the AwsBaseRequest here.
There was a problem hiding this comment.
It would also allow you to change this one to a record.
There was a problem hiding this comment.
Created a new class BaseRequest to extend from AwsBaseRequest .
Converted ExtractionRequest to a record.
sbuettner
reviewed
Oct 16, 2024
|
@sahilbhatoacamunda Congrats to your first Connector 🥳 and great work. Added just a smaller comments regarding the model. From my perspective its fine for now that you implemented your own polling although its somewhat duplicated in the textract connector right now but we can generalize later rather than now. |
...s/idp-extraction/src/main/java/io/camunda/connector/idp/extraction/caller/BedrockCaller.java
Fixed
Show fixed
Hide fixed
sbuettner
reviewed
Oct 16, 2024
...idp-extraction/src/main/java/io/camunda/connector/idp/extraction/model/ExtractionResult.java
Outdated
Show resolved
Hide resolved
…g to allow json objects
|
@sahilbhatoacamunda Great work. Looks like there are some tests failing. |
sbuettner
approved these changes
Oct 17, 2024
mathias-vandaele
added a commit
that referenced
this pull request
Oct 25, 2024
… connector (#3482) * feat(idp extraction connector): implement new idp extraction outbound connector * Removed new idp connector reference from pom.xml * Updated pom.xml to include new connector in the bundle. * Fixed code formatting * Added `io.camunda.connector:connector-aws-base` as dependency in connector build stage. * Create the new class to extend AWS base request. ExtractorRequest is refactored to be a record. * Modified ExtractionResult to have Object as response instead of string to allow json objects * Updated icon for the connector. * fix(idp-connector) change snapshot version of mail integration test --------- Co-authored-by: Mathias Vandaele <[email protected]>
mathias-vandaele
added a commit
that referenced
this pull request
Oct 28, 2024
… connector (#3482) * feat(idp extraction connector): implement new idp extraction outbound connector * Removed new idp connector reference from pom.xml * Updated pom.xml to include new connector in the bundle. * Fixed code formatting * Added `io.camunda.connector:connector-aws-base` as dependency in connector build stage. * Create the new class to extend AWS base request. ExtractorRequest is refactored to be a record. * Modified ExtractionResult to have Object as response instead of string to allow json objects * Updated icon for the connector. * fix(idp-connector) change snapshot version of mail integration test --------- Co-authored-by: Mathias Vandaele <[email protected]>
mathias-vandaele
added a commit
that referenced
this pull request
Oct 28, 2024
… connector (#3482) * feat(idp extraction connector): implement new idp extraction outbound connector * Removed new idp connector reference from pom.xml * Updated pom.xml to include new connector in the bundle. * Fixed code formatting * Added `io.camunda.connector:connector-aws-base` as dependency in connector build stage. * Create the new class to extend AWS base request. ExtractorRequest is refactored to be a record. * Modified ExtractionResult to have Object as response instead of string to allow json objects * Updated icon for the connector. * fix(idp-connector) change snapshot version of mail integration test --------- Co-authored-by: Mathias Vandaele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the integration of an outbound IDP extraction connector. This connector uses AWS Bedrock and Textract/Apache PdfBox to extract the text and then analyze it based on the input taxonomy.
Related issues
closes https://github.com/camunda/product-hub/issues/2527
Checklist
no milestonelabel.